This repository was archived by the owner on Jan 17, 2022. It is now read-only.
Updated the service. #112
Merged
Updated the service. #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was working on the typescript version, while i was re-writing some parts i noticed some things could be simplified, so i did it :) |
mendhak
reviewed
Feb 28, 2017
example/app.js
Outdated
| showBullets: true, | ||
| exitOnOverlayClick: false, | ||
| exitOnEsc:false, | ||
| nextLabel: '<strong>Proximo!</strong>', |
There was a problem hiding this comment.
Please can you keep these in English
There was a problem hiding this comment.
sure , i'll look onto that tonight
millerscout
force-pushed
the
ngIntroAsService-fixes
branch
5 times, most recently
from
c5fc4d5 to
f8d3a43
Compare
|
i reviewed the code the code again, and updated the examples and readme.md.
|
- updated service, so that's possible to make chainable methods. - removed promises... it's better to call the callback instead; - removed deferList. - removed triggers from directive, it wasn't a clean solutions, now it's using the service directly,. - updated version and build - Update README.md - added ´ng-intro-disable-button´ a directive responsible to disable/enable buttons when the intro opens and when the directive is added to a DOM. - updated the example. - added wiki url; - fixed some typos. - fixed version.
millerscout
force-pushed
the
ngIntroAsService-fixes
branch
from
f8d3a43 to
04bf5db
Compare
This was referenced Mar 4, 2017
millerscout
added a commit
that referenced
this pull request
Mar 4, 2017
- removed triggers, as it's faster work with callbacks directly and give control to the developer that needs it. - updated examples. - added a directive to help disable buttons when needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated version and build
Update README.md